perf: completely eradicate large vector allocations and state locking double-clones in main, meta, env, workspaces, and notes modules

server/src/handlers_v2/workspaces.rs

@@ -147,17 +147,14 @@ impl McpTool for SearchSnippetsHandler {
     async fn execute(&self, args: Value, state: Arc<MemoryState>) -> Result<String, String> {
         let req: SearchSnippetsTool = serde_json::from_value(args).map_err(|e| e.to_string())?;
         let query = req.query.to_lowercase();
-        let snippets = state.snippets.read();
-        let mut results = Vec::new();
-        for s in snippets {
-            if contains_ignore_ascii_case(&s.name, &query)
-                || contains_ignore_ascii_case(&s.description, &query)
-                || contains_ignore_ascii_case(&s.language, &query)
-            {
-                results.push(s);
-            }
-        }
-        let data = serde_json::to_string(&results).unwrap_or_default();
+        let data = state.snippets.read_with(|snippets| {
+            let results: Vec<_> = snippets.iter().filter(|s| {
+                contains_ignore_ascii_case(&s.name, &query)
+                    || contains_ignore_ascii_case(&s.description, &query)
+                    || contains_ignore_ascii_case(&s.language, &query)
+            }).cloned().collect();
+            serde_json::to_string(&results).unwrap_or_default()
+        });
         Ok(data.to_string())
     }
 }