Refactor: Migrate unwrap calls to AppError in MCP handlers

This commit is contained in:
Riz Ashraf committed 2026-09-30 21:02:50 +01:00
1 parent 4e1a633dbd
commit 0e866f2465
12 files changed
+276 -326

No files matched your search

+6 -6
View File
@@ -22,10 +22,10 @@ impl McpTool for WatchProcessLogsHandler {
)
}
async fn execute(&self, args: Value, _state: Arc<MemoryState>) -> Result<String, String> {
async fn execute(&self, args: Value, _state: Arc<MemoryState>) -> crate::error::Result<String> {
let tool_args: WatchProcessLogsTool = serde_json::from_value(args).map_err(|e| e.to_string())?;
if !std::path::Path::new(&tool_args.file_path).exists() {
return Err(format!("File does not exist: {}", tool_args.file_path));
return Err(crate::error::AppError::Internal(format!("File does not exist: {}", tool_args.file_path)));
}
Ok(format!("Started watching logs for {}", tool_args.file_path))
}
@@ -46,11 +46,11 @@ impl McpTool for GetRecentLogsHandler {
)
}
async fn execute(&self, args: Value, _state: Arc<MemoryState>) -> Result<String, String> {
async fn execute(&self, args: Value, _state: Arc<MemoryState>) -> crate::error::Result<String> {
let tool_args: GetRecentLogsTool = serde_json::from_value(args).map_err(|e| e.to_string())?;
let result = tokio::task::spawn_blocking(move || -> Result<String, String> {
let mut file = File::open(&tool_args.file_path).map_err(|e| format!("Failed to open file: {}", e))?;
let result = tokio::task::spawn_blocking(move || -> crate::error::Result<String> {
let mut file = File::open(&tool_args.file_path).map_err(|e| crate::error::AppError::Internal(format!("Failed to open file: {}", e)))?;
let len = file.metadata().map_err(|e| e.to_string())?.len();
let read_size = std::cmp::min(16 * 1024, len);
@@ -69,7 +69,7 @@ impl McpTool for GetRecentLogsHandler {
Ok(recent_lines)
})
.await
.map_err(|e| format!("Task panic: {}", e))??;
.map_err(|e| crate::error::AppError::Internal(format!("Task panic: {}", e)))??;
Ok(result)
}